Skip to content

net: TestFileConn failures #73683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 12, 2025 · 6 comments
Closed

net: TestFileConn failures #73683

gopherbot opened this issue May 12, 2025 · 6 comments
Assignees
@qmuntal
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. OS-Windows release-blocker
Milestone
Go1.25

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestFileConn
    file_test.go:118: got &net.TCPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:49169, Zone:""}; want &net.UDPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:49169, Zone:""}
--- FAIL: TestFileConn (0.00s)

— watchflakes
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"
2025-05-12 19:50 gotip-windows-arm64 go@019d7987 net.TestFileConn (log) 
=== RUN   TestFileConn
    file_test.go:118: got &net.TCPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:49169, Zone:""}; want &net.UDPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:49169, Zone:""}
--- FAIL: TestFileConn (0.00s)

— watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 12, 2025
@qmuntal qmuntal self-assigned this May 13, 2025
@qmuntal qmuntal added this to the Go1.25 milestone May 13, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/672195 mentions this issue: net: use closesocket when closing socket os.File's on Windows

@dmitshur dmitshur moved this to Active in Test Flakes May 13, 2025
@dmitshur dmitshur added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 13, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"
2025-05-13 03:23 gotip-windows-arm64 go@a2fbb503 net.TestFileConn (log) 
=== RUN   TestFileConn
    file_test.go:107: file file+net unix:@->C:\Users\swarming\.swarming\w\ir\x\t\1104179976\sock: protocol not supported
--- FAIL: TestFileConn (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"
2025-05-14 22:10 gotip-windows-amd64-race go@de86d02c net.TestFileConn (log) 
=== RUN   TestFileConn
    file_test.go:118: got &net.TCPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:58415, Zone:""}; want &net.UDPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:58415, Zone:""}
--- FAIL: TestFileConn (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"
2025-05-15 02:12 gotip-windows-amd64-race go@3ea94ae4 net.TestFileConn (log) 
=== RUN   TestFileConn
    file_test.go:118: got &net.TCPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:59725, Zone:""}; want &net.UDPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:59725, Zone:""}
--- FAIL: TestFileConn (0.00s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes May 15, 2025
@qmuntal qmuntal mentioned this issue May 15, 2025
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestFileConn"
2025-05-15 02:12 gotip-windows-arm64 go@3ea94ae4 net.TestFileConn (log) 
=== RUN   TestFileConn
    file_test.go:118: got &net.TCPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:58557, Zone:""}; want &net.UDPAddr{IP:net.IP{0x7f, 0x0, 0x0, 0x1}, Port:58557, Zone:""}
--- FAIL: TestFileConn (0.00s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qmuntal qmuntal

Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. OS-Windows release-blocker
Projects
Test Flakes
Status: Done
Milestone
Go1.25
Development

No branches or pull requests
3 participants
@dmitshur @qmuntal @gopherbot