Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark endpoint issue. #294

Open
zhaoyuheng200 opened this issue Feb 5, 2025 · 3 comments
Open

benchmark endpoint issue. #294

zhaoyuheng200 opened this issue Feb 5, 2025 · 3 comments
Assignees
Labels
stat:awaiting model-navigator The issue is actively being worked on by our navigators type:others issues not falling in bug, perfromance, support, build and install or feature

Comments

@zhaoyuheng200
Copy link

Hi,
I tried to use the benchmark endpint /?benchmark=1 but encountered NullInjectorError

ERROR NullInjectorError: R3InjectorError(Standalone[i])[i -> i -> i]: 
  NullInjectorError: No provider for i!

I did a shallow investigation and located the issue on edge_overlays_service.ts.

I did a simple fix by updating the @Injectable() to @Injectable(providedIn:'root'), which makes the benchmark tool work.

But I'm not sure if that's the correct fix.

Would you please investigate?

Thanks,
Neil

@endic-sam928281
Copy link

Hello, we tried to solve the issue.

This is what we did:

To fix the NullInjectorError, we need to update the EdgeOverlaysService injection. Instead of using @Injectable(providedIn:'root'), we'll add the service to the providers array in the app.config.ts file. This ensures that the service is available throughout the application, including the benchmark endpoint.

You can review changes in this commit: endic-sam928281@3ebc57e.

Caution

Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.


Latta AI seeks to solve problems in open source projects as part of its mission to support developers around the world. Learn more about our mission at https://latta.ai/ourmission . If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

@pkgoogle
Copy link
Contributor

pkgoogle commented Feb 5, 2025

Hi @jinjingforever, can you please take a look? Thanks.

@pkgoogle pkgoogle added type:others issues not falling in bug, perfromance, support, build and install or feature stat:awaiting model-navigator The issue is actively being worked on by our navigators labels Feb 5, 2025
@jinjingforever
Copy link
Collaborator

Hi @zhaoyuheng200 thanks for the report! I will submit a fix soon. (the fix would be to add the service to here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting model-navigator The issue is actively being worked on by our navigators type:others issues not falling in bug, perfromance, support, build and install or feature
Projects
None yet
Development

No branches or pull requests

5 participants