Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggcr: github.com/docker/docker v28.0.1 breaks interface #2072

Open
imjasonh opened this issue Feb 26, 2025 · 1 comment
Open

ggcr: github.com/docker/docker v28.0.1 breaks interface #2072

imjasonh opened this issue Feb 26, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@imjasonh
Copy link
Collaborator

Using v28.0.1 we can't build pkg/v1/daemon:

Error: ../../../go/pkg/mod/github.com/google/[email protected]/pkg/v1/daemon/options.go:40:9: cannot use client.NewClientWithOpts(client.FromEnv) (value of type *client.Client) as Client value in return statement: *client.Client does not implement Client (wrong type for method ImageHistory)
		have ImageHistory(context.Context, string, ...client.ImageHistoryOption) ([]image.HistoryResponseItem, error)
		want ImageHistory(context.Context, string) ([]image.HistoryResponseItem, error)

To fix this for now, you can pin this in your go.mod

	github.com/docker/docker v27.5.1+incompatible

This won't work forever. Updating the interface to accept v28's signature will break folks that use it with < v28 :-/

@imjasonh
Copy link
Collaborator Author

moby/moby#49466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant