Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More rounding methods: {long, BigInteger, BigDecimal} -> double #3895

Open
lowasser opened this issue May 8, 2020 · 0 comments
Open

More rounding methods: {long, BigInteger, BigDecimal} -> double #3895

lowasser opened this issue May 8, 2020 · 0 comments
Assignees
@lowasser
Labels
P3 no SLO package=math type=addition A new feature

Comments

@lowasser
Copy link
Contributor

lowasser commented May 8, 2020

https://stackoverflow.com/q/61669813/869736 asked for long-to-double with nonstandard rounding modes. Seems potentially worth providing -- not a lot of API surface area, hard to do, fits well with the existing utilities -- though BigDecimalMath would be new.
@lowasser lowasser changed the title More rounding methods: {log, BigInteger, BigDecimal} -> double More rounding methods: {long, BigInteger, BigDecimal} -> double May 8, 2020
dhruvdthakkar pushed a commit to dhruvdthakkar/guava that referenced this issue May 14, 2020
More rounding methods: {long, BigInteger, BigDecimal} ->double google…
9d5b75f 
…#3895
This was referenced May 14, 2020
Closed
Closed
@lowasser lowasser self-assigned this May 14, 2020
@netdpb netdpb mentioned this issue Jun 5, 2020
Merged
netdpb pushed a commit that referenced this issue Jun 5, 2020
@lowasser @netdpb
Implement BigIntegerMath.roundToDouble, which rounds to the nearest r…
d01a196 
…epresentable double value.

Partially implements #3895

RELNOTES=`math`: Added `BigIntegerMath.roundToDouble`.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=314837286
netdpb pushed a commit that referenced this issue Jun 5, 2020
@lowasser @netdpb
Implement BigIntegerMath.roundToDouble, which rounds to the nearest r…
2b5c096 
…epresentable double value.

Partially implements #3895

RELNOTES=`math`: Added `BigIntegerMath.roundToDouble`.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=314837286
@nick-someone nick-someone mentioned this issue Jun 18, 2020
Merged
nick-someone pushed a commit that referenced this issue Jun 18, 2020
@lowasser @nick-someone
Add LongMath.roundToDouble.
6f17659 
RELNOTES=Add LongMath.roundToDouble (#3895)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=316951853
nick-someone pushed a commit that referenced this issue Jun 18, 2020
@lowasser @nick-someone
Add LongMath.roundToDouble.
633abf2 
RELNOTES=Add LongMath.roundToDouble (#3895)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=316951853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowasser lowasser

Labels
P3 no SLO package=math type=addition A new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lowasser @kluever