Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application/gzip media type missing in MediaType #3946

Open
breucode opened this issue Jun 29, 2020 · 2 comments
Open

application/gzip media type missing in MediaType #3946

breucode opened this issue Jun 29, 2020 · 2 comments
Assignees
Labels
P3 package=net type=defect Bug, not working as expected

Comments

@breucode
Copy link

According to https://tools.ietf.org/html/rfc6713, media types like application/x-gzip should not be used any more, since they are non standard.
However, in the MediaType class of guava, GZIP is defined as this MediaType GZIP = createConstant(APPLICATION_TYPE, "x-gzip");. In my opinion, this encourages the usage of "deprecated" mimetypes in a lot of applications.

Simply replacing the current constant might be a problem though, so it make make sense to introduce application/gzip as an additional mimetype.

@kluever kluever added P3 package=net type=defect Bug, not working as expected labels Jun 30, 2020
@kluever
Copy link
Member

kluever commented Jun 30, 2020

Interesting - we may want to deprecate the old constant and provide a new one (it's unlikely that we could just change it in place).

@somayaj
Copy link

somayaj commented Nov 12, 2021

@cpovirk what should it be named? the final constant for GZIP?

@deprecated
public static final MediaType GZIP = createConstant(APPLICATION_TYPE, "x-gzip");

public static final MediaType GZIP = createConstant(APPLICATION_TYPE, "gzip"); // we need a name here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 package=net type=defect Bug, not working as expected
Projects
None yet
Development

No branches or pull requests

5 participants
@cpovirk @kluever @breucode @somayaj and others