Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust's nightly build issues with CI tests #867

Closed
reyammer opened this issue Jan 19, 2025 · 0 comments · Fixed by #880
Closed

Fix rust's nightly build issues with CI tests #867

reyammer opened this issue Jan 19, 2025 · 0 comments · Fixed by #880
Assignees
@ia0
Labels
rust Pull requests that update Rust code

Comments

@reyammer
Copy link
Collaborator

Context: I've just merged #866, which introduces the new standard_v3_0 model. All tests pass, except some related to rust's nightly build (which don't seem related to the new model, I've seen they also fail in #852).
@reyammer reyammer added the rust Pull requests that update Rust code label Jan 19, 2025
ia0 added a commit to ia0/magika that referenced this issue Jan 20, 2025
@ia0
Fix nightly lints
18e73a5 
Also do not fail the workflow when nightly fails. The situations where the nightly job fails but the
stable job doesn't, shouldn't block merging a PR. In particular, nightly is not hermetic (by
design), so shouldn't block merging a PR for this simple reason alone.

Fixes google#867
@ia0 ia0 mentioned this issue Jan 20, 2025
Merged
ia0 added a commit to ia0/magika that referenced this issue Jan 20, 2025
@ia0
Fix nightly lints
a9b7d73 
Also do not fail the workflow when nightly fails. The situations where the nightly job fails but the
stable job doesn't, shouldn't block merging a PR. In particular, nightly is not hermetic (by
design), so shouldn't block merging a PR for this simple reason alone.

Fixes google#867
@ia0 ia0 closed this as completed in #880 Jan 20, 2025
ia0 added a commit that referenced this issue Jan 20, 2025
@ia0
Fix nightly lints (#880)
8eb86c1 
Also do not fail the workflow when nightly fails. The situations where the nightly job fails but the
stable job doesn't, shouldn't block merging a PR. In particular, nightly is not hermetic (by
design), so shouldn't block merging a PR for this simple reason alone.

Fixes #867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ia0 ia0

Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nightly lints ia0/magika
2 participants
@ia0 @reyammer