Remove audienceSegmentation feature flag once the feature is fully rolled out

[techanvil]

Feature Description

When the Audience Segmentation feature has been rolled out to 100% of users, the audienceSegmentation feature flag should be removed.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• With Audience Segmentation at 100% rollout, the audienceSegmentation feature flag should be removed.
• The flag itself, all references to it, and all execution paths that are taken when the flag is false should be removed from the codebase.

Implementation Brief

• Remove the use of the feature flag from the following files:

  • site-kit-wp/feature-flags.json

    Line 3 in 846d233

    "audienceSegmentation",

  • site-kit-wp/assets/js/googlesitekit/widgets/register-defaults.js

    Line 152 in 846d233

    if ( isFeatureEnabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/assets/js/modules/analytics-4/index.js

    Line 715 in 846d233

    ! isFeatureEnabled( 'audienceSegmentation' )

  • site-kit-wp/assets/js/modules/analytics-4/index.js

    Line 775 in 846d233

    ! isFeatureEnabled( 'audienceSegmentation' )

  • site-kit-wp/assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.test.js

    Line 475 in 846d233

    features: [ 'audienceSegmentation' ],

  • site-kit-wp/includes/Core/User/REST_Audience_Settings_Controller.php

    Line 65 in 846d233

    if ( Feature_Flags::enabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/includes/Core/User/REST_Audience_Settings_Controller.php

    Line 91 in 846d233

    if ( ! Feature_Flags::enabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/includes/Modules/Analytics_4.php

    Line 346 in 846d233

    if ( Feature_Flags::enabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/includes/Modules/Analytics_4.php

    Lines 579 to 580 in 846d233

    	// Check if the audienceSegmentation feature is enabled.
    	if ( Feature_Flags::enabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/includes/Modules/Analytics_4.php

    Line 695 in 846d233

    if ( Feature_Flags::enabled( 'audienceSegmentation' ) ) {

  • site-kit-wp/tests/phpunit/integration/Core/User/REST_Audience_Settings_ControllerTest.php

    Line 96 in 846d233

    $this->enable_feature( 'audienceSegmentation' );

  • All uses of $this->enable_feature( 'audienceSegmentation' ); can be removed from tests/phpunit/integration/Modules/Analytics_4Test.php

Test Coverage

• Confirm all tests pass with this feature flag removed.

QA Brief

1. audienceSegmentation feature flag should no longer be available in tester plugin.

2. Make sure that Audience Segmentation functionality continues to function without any issues after removal of the feature flag. Following are the points which can be tested.

3. Audience segmentation setup CTA widget banner should be visible.

4. After setting up the feature success subtle notification should be visible.

5. Ensure that audiences' selection is working fine and getting saved properly.

6. Audience segmentation debug fields are present in site health section.

7. Test the secondary user setup is working as expected.

Changelog entry

• Remove the audienceSegmentation feature flag.

[techanvil]

IB ✅

[wpdarren]

@kelvinballoo @mohitwp I suspect the QAB will mention this but just in case, as part of this testing we should ensure that Audience Segmentation continues to function as engineered when the feature flag is removed. In the past, we've had issues where removal of the feature flag broke functionality. 😄

[aaemnnosttv]

Assigning to @ankitrox while Junio is OOO to finish this one up. This will make issue #8888 he's been working on simpler as well.

[ankitrox]

Hello @techanvil,

I have assigned this issue to you for CR mainly to review the E2E changes. The changes you suggested seems to be working as expected. E2E tests are still seem to be failing in CI pipeline, but these errors are irrelevant to the issue in progress. Feel free to unassign yourself in case you don't have bandwidth to look into this.

Thank you.

[techanvil]

Thanks @ankitrox. I've reviewed and merged the PR - please note, it did need a few updates which I applied myself to save the round trip. Cc @juniovitorino.

Ankit, please can you revise the QAB to include a mention of verifying the secondary user setup flow. I'd also suggest the point about confirming the user/data/audience-settings endpoint is still present can be replaced with something more user-centric, e.g. verifying the audience selection still works as expected.

Basically we just want to smoke test the Audience Segmentation feature, although it is useful to highlight some specific areas where it makes sense, as you have done.

[ankitrox]

Thank you @techanvil , I have updated the QAB as per the suggestions. For the secondary user setup, I have linked it to the design doc for secondary user setup so that the functionality can be referenced over there.

[mohitwp]

QA Update ❌

• Tested on dev environment.
• Verified that the audienceSegmentation feature flag is now removed from tester plugin.

@ankitrox Audience segmentation functionality is not working correctly in the dev environment.

Issue 1 - Set up Success state notice is not showing.

Recording.1901.mp4

Issue 2: Clicking on 'Change Groups' Does Not Open the Selection Panel

Recording.1902.mp4

Issue 3: 'Visitor groups' section is not showing under Admin Settings.

Recording.1903.mp4

[techanvil]

@ankitrox, it looks like there are still some feature flag checks in the codebase that were somehow missed:

assets/js/modules/analytics-4/index.js
725:            featureFlag: 'audienceSegmentation',

assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.test.js
112:            enabledFeatures.add( 'audienceSegmentation' );

assets/js/components/OverlayNotification/OverlayNotificationsRenderer.js
37:     const audienceSegmentationEnabled = useFeature( 'audienceSegmentation' );

assets/js/components/DashboardMainApp.js
85:     const audienceSegmentationEnabled = useFeature( 'audienceSegmentation' );

assets/js/components/settings/SettingsAdmin.js
45:     const audienceSegmentationEnabled = useFeature( 'audienceSegmentation' );

[ankitrox]

Thank you @mohitwp for testing this and @techanvil for spotting few more instances of feature flag. I have created a follow-up PR #10458 to fix the issues and this seems to be working fine now.

Related video: https://www.loom.com/share/7ebb46a71aba43d5a8cf396d70b3b940?sid=5e2b0972-3125-4c88-9d34-7cada4c84e20

Moving this issue to CR.

[techanvil]

That's great, thanks @ankitrox. The PR is merged, back over to you @mohitwp.

[mohitwp]

QA Update ✅

• Tested on main environment.
• Verified audienceSegmentation feature flag not available in tester plugin.
• Verified for Google a/c which already have permissions.
• Verified for Google a/c which don't have permissions and need to go through OAuth flow.
• Verified Audience segmentation setup CTA widget banner is visible.
• Verified After setting up the feature success subtle notification is visible.
• Verified that audiences' selection is working fine and getting saved properly.
• Verified Group sections functionality under Admin settings.
• Verified view only user.

Recording.1920.mp4

Recording.1921.mp4

Recording.1922.mp4