Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libertarian Party not handled when displaying vote details #243

Open
GPHemsley opened this issue Dec 29, 2020 · 2 comments
Open

Libertarian Party not handled when displaying vote details #243

GPHemsley opened this issue Dec 29, 2020 · 2 comments

Comments

@GPHemsley
Copy link
Contributor

GPHemsley commented Dec 29, 2020

https://www.govtrack.us/congress/votes/116-2020/h252
image

Looks like the code was written to call out DIR explicitly and defaulting to unstyled/full name otherwise, presumably to quickly implement the functionality without having to deal with historical data:
dcb22ab
dda0e21

Support should be added for displaying L in a yellow box, using class party_L. Wikipedia uses #FED105. Their logo uses #FFD03C and #56565B.

.partycolor_D { color: #008ed1; }
.partycolor_R { color: #f83631; }
.partycolor_I { }
.party_D, .party_I, .party_R {
cursor: default;
color: white;
}
.color_D, .party_D { background-color: #008ed1; }
.color_R, .party_R { background-color: #f83631; }
.color_I { background-color: #921b85; }
.party_I { border: 1px solid #555; color: black; }
/* historical parties... the other letters of the alphabet */
.color_A, .color_B, .color_C, .color_E, .color_F, .color_G, .color_H, .color_J, .color_K, .color_L, .color_M, .color_N, .color_O, .color_P, .color_Q, .color_S, .color_T, .color_U, .color_V, .color_W, .color_X, .color_Y, .color_Z { background-color: #EEE; }
.vote_positive { background-color: #EFE; }
.vote_negative { background-color: #FEE; }
#dotchart { position: relative; font-size: 11px; margin-bottom: 10px; }
#dotchart .dot { position: absolute; width: 6px; height: 6px; }
#dotchart .party_I { width: 4px; height: 4px; }

Here's a mockup of what it could look like:
image

(FWIW, Wikipedia also has colors for historical parties.)

@JoshData
Copy link
Member

Hey @GPHemsley! Good point, though with Amash leaving this isn't super high priority, but I will try to fix it since the pages live forever. :)

@GPHemsley
Copy link
Contributor Author

I expect in the long run he won't be the only one. ;)

Plus he seems to be the first in recent memory to switch to a non-independent 3rd party while in office:
https://en.wikipedia.org/wiki/List_of_United_States_Representatives_who_switched_parties

The other two on that list worth looking into are Franklin D. Roosevelt, Jr. (Liberal) and William Carney (Conservative), both of whom appear to have originally been elected thanks to New York's fusion voting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants