Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If fit goes wrong convergence test can report positively although fit didn't converge #15

Open
jkfindeisen opened this issue Aug 10, 2017 · 1 comment

Comments

@jkfindeisen
Copy link
Collaborator

If for some reason the first step is too large (too large lambda?), the parameters are way off after the first iteration and then never recover, but still chi_square-previous_chi_square will be zero sometimes and the convergence test will be positive although the model and the parameters are far from anything good.

Not sure yet, what exactly is wrong there and how to fix it but it surely deserves to be looked at.

This may also happen in other fit frameworks, but maybe not to the same extent. The value of the initial lambda parameter as well as a more complex analysis of the converged state may improve the situation

@superchromix
Copy link
Collaborator

@jkfindeisen Please post an example code which reproduces the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants