From 6fec1eb43a973cdcd0c1120ad4aed27893999443 Mon Sep 17 00:00:00 2001 From: Matias Bordese Date: Mon, 8 Jul 2024 11:02:32 -0300 Subject: [PATCH] Handle unexpected recipient value. Add logging. (#4626) Related to https://github.com/grafana/oncall-private/issues/2683 --- engine/apps/email/inbound.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/engine/apps/email/inbound.py b/engine/apps/email/inbound.py index 5a37daa375..76eec2aaca 100644 --- a/engine/apps/email/inbound.py +++ b/engine/apps/email/inbound.py @@ -86,7 +86,13 @@ def get_integration_token_from_request(self, request) -> Optional[str]: # First try envelope_recipient field. # According to AnymailInboundMessage it's provided not by all ESPs. if message.envelope_recipient: - token, domain = message.envelope_recipient.split("@") + try: + token, domain = message.envelope_recipient.split("@") + except ValueError: + logger.error( + f"get_integration_token_from_request: envelope_recipient field has unexpected format: {message.envelope_recipient}" + ) + return None if domain == live_settings.INBOUND_EMAIL_DOMAIN: return token else: