Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define some constants in typescript declaration file #113

Open
kaktus40 opened this issue Mar 1, 2019 · 0 comments
Open

define some constants in typescript declaration file #113

kaktus40 opened this issue Mar 1, 2019 · 0 comments

Comments

@kaktus40
Copy link

kaktus40 commented Mar 1, 2019

Hello,
In the code, you defined some named numbers that could be used in twgl. I think that you should add these named values in the typescript declaration file:
instead of internalFormat?: number; in line 154 you could declare
internalFormat?:internalFormatType
ẁith
export type internalFormatType = 'R8' | 'R32F' | 'R16UI' | 'R16I' | 'R32UI' | 'R32I' | 'RG8' | 'RG32F' | 'RG16UI' | 'RG16I' | 'RG32UI' | 'RG32I' | 'RGB8' | 'RGB32F' | 'RGB16UI' | 'RGB16I' | 'RGB32UI' | 'RGB32I' | 'RGBA8' | 'RGBA32F' | 'RGBA16UI' | 'RGBA16I' | 'RGBA32UI' | 'RGBA32I'; for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant