Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-existing variable name in ValueError message results in NameError being raised instead #286

Closed
lbianchi-lbl opened this issue Jun 23, 2022 · 0 comments · Fixed by #287
Assignees

Comments

@lbianchi-lbl
Copy link

We've encountered this while working on DISPATCHES (see gmlc-dispatches/dispatches#119 (comment)).

My understanding is that the _read_metadata() function correctly detected that the simulation_objects.csv file was missing, but the error message refers to a non-existing variable which causes a NameError to be raised:

def _read_metadata(base_dir:str) -> pd.DataFrame:
metadata_path = os.path.join(base_dir, "simulation_objects.csv")
if not os.path.exists(metadata_path):
raise ValueError(f'RTS-GMLC directory "{rts_gmlc_dir}" does not contain expected CSV files.')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants