Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths containing .. bug #29

Closed
dom96 opened this issue Oct 1, 2021 · 2 comments
Closed

Paths containing .. bug #29

dom96 opened this issue Oct 1, 2021 · 2 comments

Comments

@dom96
Copy link
Contributor

dom96 commented Oct 1, 2021

I can understand not supporting extraction of paths that are relative, but I think this is an edge case that isn't relative and also isn't supported:

Extracting paths containing `...` is not supported (nim-1.0.4/c_code/7_1/@m..@slib@spackages@[email protected])

This is from from nim-1.0.4-linux_x64.tar.xz.

I have similar checks in my library which it seems I was also not sure about (https://github.com/dom96/untar/blob/master/src/untar.nim#L149), but I think checking for just ".." is too broad.
@guzba
Copy link
Owner

guzba commented Oct 2, 2021

Ah thanks for making an issue. I definitely would like to allow that path. The .. check was just "simple" in the moment, not really ever meant to be perfect. Let's improve it.

@guzba guzba closed this as completed in f6dda64 Oct 5, 2021
guzba added a commit that referenced this issue Oct 5, 2021
@guzba
Merge pull request #30 from dom96/fixes-29
fbe73f8 
Fixes #29; filenames containing `..` being rejected.
@guzba
Copy link
Owner

guzba commented Oct 5, 2021

Changes released in zippy 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dom96 @guzba