Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - md-menu tour step closes on button focus #189

Open
2 of 9 tasks
em843 opened this issue Sep 19, 2024 · 2 comments
Open
2 of 9 tasks

🐞 - md-menu tour step closes on button focus #189

em843 opened this issue Sep 19, 2024 · 2 comments
Labels
bug Something isn't working P3 upstream-issue

Comments

@em843
Copy link

em843 commented Sep 19, 2024

Which ngx-ui-tour-* package is the source of the bug?

md-menu

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-wau2z8?file=src%2Fapp%2Fui-tour-demo.component.ts

Description

If you click on the tour card to focus it and then hit "tab", the close button is automatically pressed and the tour ends. The expected behavior is navigating to the close button without pressing it, and then being able to navigate using the tab key to the previous/next buttons. This bug renders the tour unusable for keyboard users.

Can reproduce it on the demo tour in docs: https://hakimio.github.io/ngx-ui-tour/md-menu

Angular version

15.2.10

Ngx UI Tour version

10.0.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@em843 em843 added bug Something isn't working needs-triage labels Sep 19, 2024
@hakimio hakimio changed the title 🐞 - Tour closes on "tab" and is not keyboard-navigable 🐞 - Tour closes on "tab" Sep 20, 2024
@hakimio hakimio added P3 and removed needs-triage labels Sep 20, 2024
@hakimio
Copy link
Owner

hakimio commented Sep 20, 2024

While the tour closing on focus is a valid bug, the tour does support keyboard shortcuts and they are described in the docs: Hotkeys

@hakimio hakimio changed the title 🐞 - Tour closes on "tab" 🐞 - [md-menu] Tour closes on button focus Sep 20, 2024
@hakimio hakimio changed the title 🐞 - [md-menu] Tour closes on button focus 🐞 - md-menu Tour closes on button focus Sep 20, 2024
@hakimio
Copy link
Owner

hakimio commented Sep 20, 2024

Seems to be Material menu bug:
angular/components#29420
angular/components#27878

@hakimio hakimio changed the title 🐞 - md-menu Tour closes on button focus 🐞 - md-menu tour step closes on button focus Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 upstream-issue
Projects
None yet
Development

No branches or pull requests

2 participants