Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition #17

Open
deano2390 opened this issue Feb 25, 2019 · 1 comment
Open

Race condition #17

deano2390 opened this issue Feb 25, 2019 · 1 comment

Comments

@deano2390
Copy link

I notice that the initial loading of strings is handled in an async task when you init the restring library in Application.onCreate();

This means that your first Activity can be shown before the loading of strings is complete and it therefore fails to show the dynamic strings.

I suggest allowing a way to synchronously initialise the string repository at boot time. This means locking the UI thread briefly but at least guarantees your strings will be ready before the first activity is presented.

@deano2390
Copy link
Author

Just to be clear, in my scenario the string loading is done by loading an xml file from disk which can be slow, slow enough in my case to cause the mentioned behaviour at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant