-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@babel/preset-react and babel-plugin-dynamic-import-node #257
Comments
Because they're runtime dependencies:
|
@ljharb I agree, but for example here happo.io/src/createWebpackBundle.js Line 10 in c4eb30a
I'm asking, because we are using Happo with Cypress, without any babel configurations, and I'm wondering how can I avoid it. as I understand, as soon as this is not a monorepo with more modular packages which can be published separately it is not possible? -- |
https://github.com/happo/happo.io/blob/master/package.json#L109 is where webpack is specified as a peer dep. I don't think you can avoid it. |
@ljharb can we move babel presets to peerDeps as well? (sorry for all the questions) |
Peer deps are strictly required, so that wouldn't help your problem at all - it'd just be a breaking change and additional burden on users to install them themselves. |
is there any reason why
@babel/preset-react
andbabel-plugin-dynamic-import-node
independencies
section of the package.json and not indevDependencies
?It bloats our application node_modules a lot, because of it
The text was updated successfully, but these errors were encountered: