Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve types #34

Open
airtonix opened this issue Jul 7, 2024 · 1 comment · Fixed by #35
Open

Unable to resolve types #34

airtonix opened this issue Jul 7, 2024 · 1 comment · Fixed by #35

Comments

@airtonix
Copy link
Contributor

airtonix commented Jul 7, 2024

Suggesting that you make use of

    "@arethetypeswrong/cli": "^0.15.3",

and

attw --pack

as part of your linting/test step.

reason is that your dist folder has

> ls 
index.d.ts  use-hash-param.js  use-hash-param.umd.cjs

the package.json needs to have types field:

...
  "main": "./dist/use-hash-param.js",
  "types": "./dist/use-hash-param.d.ts"
...
@hejmsdz
Copy link
Owner

hejmsdz commented Aug 5, 2024

Hi, @airtonix , thank you for your contribution!
I accepted your pull request, but it seems that even after applying these fixes, ATTW is still reporting issues for Node 10 and Node 16 CJS.

image

Do you know how to fix it? And do you think it actually matters, if Node 10 and 16 have reached end-of-life 3 years ago and almost 1 year ago, respectively?

@hejmsdz hejmsdz reopened this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants