Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Toast closed even before promise is resolved #4912

Closed
saurabhguptarock opened this issue Feb 23, 2025 · 4 comments
Closed

[BUG] - Toast closed even before promise is resolved #4912

saurabhguptarock opened this issue Feb 23, 2025 · 4 comments
Assignees

Comments

@saurabhguptarock
Copy link

HeroUI Version

2.7.2

Describe the bug

Whenever I create a toast with promise it closes before the promise is even resolved. The behaviour is that it follows timeout value and promise is only used to update the icon, which should not be the expected behaviour.

Your Example Website or App

Steps to Reproduce the Bug or Issue

addToast({
title: "Toast Title",
description: "Toast Description",
promise: new Promise((resolve) => setTimeout(resolve, 10000)),
});

Expected behavior

The toast should only close once the promise is resolved not before that.

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

Copy link

linear bot commented Feb 23, 2025

@macci001
Copy link
Contributor

macci001 commented Feb 24, 2025

Thanks @saurabhguptarock for reporting this issue.
This is already fixed and will be available in 2.7.3

@saurabhguptarock
Copy link
Author

saurabhguptarock commented Feb 24, 2025

Thanks @saurabhguptarock for reporting this issue. This is already fixed and will be available in 3.7.3

Thanks but 3.7.3 or 2.7.3?

@wingkwong
Copy link
Member

@saurabhguptarock typo. should be 2.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants