Membership options changes for release (MyCryptoHQ#3661)

* hide 3 & 6 month membership options for now * disabled memberships instead of remove them, so we can still poll for pre-existing memberships * fixed test
hijayjay · Dec 16, 2020 · a17fbdd · a17fbdd
1 parent 5812582
commit a17fbdd
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 10 deletions.
diff --git a/src/components/TransactionFlow/TxReceipt.stories.tsx b/src/components/TransactionFlow/TxReceipt.stories.tsx
@@ -136,7 +136,7 @@ export const transactionReceiptDeFiZap = wrapInProvider(
   </div>
 );
 
-const membershipSelected = MEMBERSHIP_CONFIG[IMembershipId.threemonths];
+const membershipSelected = MEMBERSHIP_CONFIG[IMembershipId.twelvemonths];
 
 export const transactionReceiptMembership = wrapInProvider(
   <div className="sb-container" style={{ maxWidth: '620px' }}>

diff --git a/src/features/PurchaseMembership/components/MembershipEducation.tsx b/src/features/PurchaseMembership/components/MembershipEducation.tsx
@@ -187,9 +187,14 @@ const MembershipEducation = withRouter(({ history }) => {
         </ListContainer>
         <Title>{translate('WHAT_IT_COST')}</Title>
         <PlanContainer>
-          {Object.keys(MEMBERSHIP_CONFIG).map((key) => (
-            <MembershipPlanCard key={key} plan={MEMBERSHIP_CONFIG[key as IMembershipId]} />
-          ))}
+          {Object.values(MEMBERSHIP_CONFIG)
+            .filter(({ disabled }) => !disabled)
+            .map((membershipConfig) => (
+              <MembershipPlanCard
+                key={membershipConfig.key}
+                plan={MEMBERSHIP_CONFIG[membershipConfig.key as IMembershipId]}
+              />
+            ))}
         </PlanContainer>
         <SButton onClick={handleSubmit}>{translate('BUY_MEMBERSHIP_NOW')}</SButton>
         <Disclaimer>{translate('MEMBERSHIP_NOTE')}</Disclaimer>

diff --git a/src/features/PurchaseMembership/components/MembershipPurchaseForm.tsx b/src/features/PurchaseMembership/components/MembershipPurchaseForm.tsx
@@ -80,7 +80,7 @@ export const MembershipFormUI = ({
 }: UIProps) => {
   const { getAssetByUUID } = useAssets();
   const { defaultAccount } = useContext(StoreContext);
-  const defaultMembership = MEMBERSHIP_CONFIG[IMembershipId.sixmonths];
+  const defaultMembership = MEMBERSHIP_CONFIG[IMembershipId.twelvemonths];
   const defaultAsset = (getAssetByUUID(defaultMembership.assetUUID as TUuid) || {}) as Asset;
   const initialFormikValues: MembershipSimpleTxFormFull = {
     membershipSelected: defaultMembership,

diff --git a/src/features/PurchaseMembership/components/MembershipSelector.test.tsx b/src/features/PurchaseMembership/components/MembershipSelector.test.tsx
@@ -35,6 +35,7 @@ describe('MembershipSelector', () => {
 
     // Ensure each plan is displayed in the list.
     Object.values(MEMBERSHIP_CONFIG)
+      .filter(({ disabled }) => !disabled)
       .map((p) => p.title)
       .forEach((t) => expect(getByText(t)).toBeInTheDocument());
   });

diff --git a/src/features/PurchaseMembership/components/MembershipSelector.tsx b/src/features/PurchaseMembership/components/MembershipSelector.tsx
@@ -43,7 +43,9 @@ export interface MembershipSelectorProps {
 }
 
 export default function MembershipSelector({ name, value, onSelect }: MembershipSelectorProps) {
-  const options: IMembershipConfig[] = Object.values(MEMBERSHIP_CONFIG);
+  const options: IMembershipConfig[] = Object.values(MEMBERSHIP_CONFIG).filter(
+    ({ disabled }) => !disabled
+  );
 
   return (
     <Selector<IMembershipConfig>

diff --git a/src/features/PurchaseMembership/config.ts b/src/features/PurchaseMembership/config.ts
@@ -22,6 +22,7 @@ export interface IMembershipConfig {
   assetUUID: string;
   durationInDays: number;
   discountNotice: string;
+  disabled?: boolean;
 }
 
 export type IMembershipConfigObject = {
@@ -77,9 +78,10 @@ export const MEMBERSHIP_CONFIG: IMembershipConfigObject = {
     icon: threemonthsIcon,
     price: '10.5',
     discount: '10',
+    disabled: true,
     assetUUID: DAIUUID,
     durationInDays: 90,
-    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '10%' })
+    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '~12.5%' })
   },
 
   sixmonths: {
@@ -90,9 +92,10 @@ export const MEMBERSHIP_CONFIG: IMembershipConfigObject = {
     icon: sixMonthsIcon,
     price: '18',
     discount: '20',
+    disabled: true,
     assetUUID: DAIUUID,
     durationInDays: 180,
-    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '20%' })
+    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '~25%' })
   },
 
   twelvemonths: {
@@ -105,7 +108,7 @@ export const MEMBERSHIP_CONFIG: IMembershipConfigObject = {
     discount: '40',
     assetUUID: DAIUUID,
     durationInDays: 366,
-    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '40%' })
+    discountNotice: translateRaw('MEMBERSHIP_DISCOUNT', { $percentage: '~37.5%' })
   },
 
   lifetime: {
@@ -114,7 +117,7 @@ export const MEMBERSHIP_CONFIG: IMembershipConfigObject = {
     contractAddress: '0x098D8b363933D742476DDd594c4A5a5F1a62326a',
     description: '',
     icon: lifetimeIcon,
-    price: '5',
+    price: '2',
     assetUUID: ETHUUID,
     durationInDays: 36500,
     discountNotice: translateRaw('MEMBERSHIP_LIFETIME_DESC')