Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bobby warnings should be reported at WARN level #14

Open
howyp opened this issue Mar 25, 2015 · 4 comments
Open

Bobby warnings should be reported at WARN level #14

howyp opened this issue Mar 25, 2015 · 4 comments

Comments

@howyp
Copy link
Contributor

howyp commented Mar 25, 2015

Bobby seems to log everything at INFO level, even if it's a warning. This seems surprising and also makes it harder to parse the warnings out of the log. Example:

[info] [bobby] Checking for out of date dependencies
[info] [bobby] 'scala-library 2.11.2' is out of date, consider upgrading to '2.11.5'
[info] [bobby] Unable to get a latestRelease number for 'com.kenshoo:metrics-play:2.3.0_0.1.6'
[info] [bobby] 'play-reactivemongo 3.1.0' is out of date, consider upgrading to '3.2.0'

I'd suggest that this should have been:

[info] [bobby] Checking for out of date dependencies
[warn] [bobby] 'scala-library 2.11.2' is out of date, consider upgrading to '2.11.5'
[info] [bobby] Unable to get a latestRelease number for 'com.kenshoo:metrics-play:2.3.0_0.1.6'
[warn] [bobby] 'play-reactivemongo 3.1.0' is out of date, consider upgrading to '3.2.0'

Not sure about what level we should log when a version number couldn't be retrieved.

@SteveSmithTech
Copy link

@howyp Would you like to submit a PR?

@charleskubicek
Copy link
Contributor

I'm not sure being a one patch version out in a dependency should be a warning. i.e 1.0.4 vs 1.0.5 shouldn't be such a big deal. I'd rather save warnings for larger version differences.

@howyp
Copy link
Contributor Author

howyp commented Mar 25, 2015

Working out what should be a warning was kind of the reason for raising an issue rather than a PR. We wanted to use bobby warnings to make CI go yellow.

@howyp
Copy link
Contributor Author

howyp commented Mar 25, 2015

What do you think the threshold for giving a warning should be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants