Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

should SinglePageStack use a vec or similar to provide an explicit structure for a stack of immutable SinglePageAllocation? #182

Open
thedavidmeister opened this issue Jul 31, 2018 · 0 comments

Comments

@thedavidmeister
Copy link
Contributor

i just had a quick look through this but IIRC:

  • SinglePageAllocation has public fields rather than getters, so can be mutated after creation
  • SinglePageStack only has top, which tracks the position of the next allocation/deallocation as a u16
  • keeping track of all SPAs in a stack and that they are FILO isn't handled by the stack itself

would it be helpful to put a Vec<SinglePageAllocation> in the SPS and make the SPA fields private?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant