Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining work #1

Open
hrbrmstr opened this issue Feb 27, 2017 · 4 comments
Open

remaining work #1

hrbrmstr opened this issue Feb 27, 2017 · 4 comments

Comments

@hrbrmstr
Copy link
Owner

Finishing up the CDX API wrapper: https://github.com/internetarchive/wayback/tree/master/wayback-cdx-server

then error/edge-case handling + writing tests + code coverage

full-disclosure: seekrit project (i suck at seekrit projects) is a FOSS book on web scraping. Full credit in book and package to all who contribute.

@jonocarroll
Copy link
Collaborator

I'll have a play.

@hrbrmstr
Copy link
Owner Author

I added some is_* helpers today since I was waiting for an online student to arrive to class and got tired of poking at Microsoft.

@jonocarroll
Copy link
Collaborator

Looking good. I'll fiddle with internals later in the week, but I'm hoping things like

if ("timestamp" %in% colnames(res)) {
   res <- dplyr::mutate_(res, "timestamp" = lazyeval::interp(~anytime::anytime(t), t = quote(timestamp)))
}

replaced with

res <- dplyr::mutate_at(res, dplyr::vars(dplyr::matches("timestamp")), dplyr::funs(anytime::anytime))

makes sense/is desired. The failing test (if there is no timestamp column) leaves res unchanged.

@hrbrmstr
Copy link
Owner Author

+1. I kinda get lazy in my pkgs and do a globalVariables() hack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants