Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for non-tls operation #23

Open
Zapeth opened this issue Apr 24, 2021 · 0 comments
Open

Add option for non-tls operation #23

Zapeth opened this issue Apr 24, 2021 · 0 comments

Comments

@Zapeth
Copy link

Zapeth commented Apr 24, 2021

I've been trying to set up a Linux server <=> Windows clients environment but every time I try to connect with a client I get:
Error: Failed to connect: The certificate's CN name does not match the passed value. (os error -2146762481)
(error constant name: CERT_E_CN_NO_MATCH)

I've already tried generating various certificates with different altNames (IP and DNS) but nothing worked.

I realize this is probably not an issue with this crate, but I'd still like to request an option to run the server without requiring a certificate.

For a quick and dirty workaround I disabled

rkvm/client/src/main.rs

Lines 34 to 37 in bf13366

let mut stream = connector
.connect(server, stream)
.await
.context("Failed to connect")?;
and

rkvm/server/src/main.rs

Lines 85 to 91 in bf13366

let stream = match acceptor.accept(stream).await {
Ok(stream) => stream,
Err(err) => {
log::error!("{}: TLS error: {}", address, err);
continue;
}
};
, but a proper configurable implementation would be obviously preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant