Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplace buffer readback is incorrect. #214

Open
FL33TW00D opened this issue Jun 18, 2024 · 1 comment
Open

Inplace buffer readback is incorrect. #214

FL33TW00D opened this issue Jun 18, 2024 · 1 comment

Comments

@FL33TW00D
Copy link
Collaborator

FL33TW00D commented Jun 18, 2024

If you have a Tensor and apply a "standard" operation to it, followed by an "inplace" operation, and then resolve the tensor and read it back to GPU, the readback result is the result of the "standard" operation.

This keeps popping up and I keep kicking the can down the road.

A simple fix (despite not knowing the underlying cause) would be do a GPU buffer copy to a fresh buffer before reading back, but i'd like to know the reason.

@FL33TW00D
Copy link
Collaborator Author

FL33TW00D commented Jun 18, 2024

image

Whisper encoder stem nicely reproduces the issue.
Readback the stem output with Binary inplace enabled and disabled.
If enabled, you get the prior permute output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant