Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per voice FX ? #39

Open
giann opened this issue May 29, 2019 · 8 comments
Open

Per voice FX ? #39

giann opened this issue May 29, 2019 · 8 comments

Comments

@giann
Copy link

giann commented May 29, 2019

Is it possible to have individual FX for each voice? Or to play a single note with an effect?
@neauoire
Copy link
Member

Pilot is a bit too limited for this kind of gymnastic at the moment, I would need some help to get this in.

@giann
Copy link
Author

giann commented May 29, 2019

I think it should be fairly simple. Just like you have a Tone.Envelope for each voice, you could have a FX parameter.

@neauoire
Copy link
Member

neauoire commented May 29, 2019 •
edited
Loading

Would you like to give it a shot and submit a PR?
I'd totally merge that.

@giann
Copy link
Author

giann commented May 29, 2019

I'll try

@neauoire
Copy link
Member

You got this ✊

@giann
Copy link
Author

giann commented May 29, 2019

What would be better? One FX slot for each voice and you can choose which effect you put there. Or all FX available for each voice and you set the amount for each of them like you do for master FX right now? I don't know how we could represent the latter in the UI without it being a little too much.

@giann
Copy link
Author

giann commented May 29, 2019 •
edited
Loading

I think one fx slot by voice is enough for now it'd be an addional column per voice:

0 0D00 8ISI WAH0F ----

giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
8ad481f 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
36c08d9 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
bc575ed 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
a622627 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
8070a9d 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
giann added a commit to giann/Pilot that referenced this issue May 29, 2019
@giann
Added an effect by voice
5d3ac80 
Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
@giann giann mentioned this issue May 29, 2019
Closed
@giann
Copy link
Author

giann commented May 29, 2019

This wasn't so hard :)
Love the fact that you didn't went for any fancy js framework: the codebase is small and really easy to understand as a consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added an effect by voice giann/Pilot
2 participants
@giann @neauoire