Skip to content

Commit 2c89d08

Browse files
pgeorgiPatrick Georgi
authored andcommitted
Documentation: Add warning about "private" changes on Gerrit
Private changes on Gerrit are a tricky beast in that they're well hidden in the UI and a few other places but still reachable under certain circumstances. Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Signed-off-by: Patrick Georgi <[email protected]> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59229 Tested-by: build bot (Jenkins) <[email protected]> Reviewed-by: Felix Singer <[email protected]>
1 parent 63c0fd2 commit 2c89d08

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

Documentation/getting_started/gerrit_guidelines.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,10 @@ the wip flag:
193193
* When pushing patches that are not for submission, these should be marked
194194
as such. This can be done in the title ‘[DONOTSUBMIT]’, or can be pushed as
195195
private changes, so that only explicitly added reviewers will see them. These
196-
sorts of patches are frequently posted as ideas or RFCs for the community
197-
to look at. To push a private change, use the command:
196+
sorts of patches are frequently posted as ideas or RFCs for the community to
197+
look at. Note that private changes can still be fetched from Gerrit by anybody
198+
who knows their commit ID, so don't use this for sensitive changes. To push
199+
a private change, use the command:
198200
git push origin HEAD:refs/for/master%private
199201

200202
* Multiple push options can be combined:

Documentation/tutorial/part2.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ When you are done with your commit, run `git push` to push your commit to
173173
coreboot.org. **Note:** To submit as a private patch, use
174174
`git push origin HEAD:refs/for/master%private`. Submitting as a private patch
175175
means that your commit will be on review.coreboot.org, but is only visible to
176-
yourself and those you add as reviewers.
176+
yourself and those you add as reviewers. This mode isn't perfect: Somebody who
177+
knows the commit ID can still fetch the change and everything it refers (e.g.
178+
parent commits).
177179

178180
This has been a quick primer on how to submit a change to Gerrit for review
179181
using git. You may wish to review the [Gerrit code review workflow

0 commit comments

Comments
 (0)