Fix a bug where tapping on a bugreport mailed the wrong one,

and don't crash if /sdcard/bugreports doesn't exist.

Author: egnor

apps/BugReportSender/src/com/android/bugreportsender/BugReportListActivity.java

@@ -30,7 +30,8 @@
 
 import java.io.File;
 import java.util.ArrayList;
-import java.util.Comparator;
+import java.util.Arrays;
+import java.util.Collections;
 
 /**
  * Shows a list of bug reports currently in /sdcard/bugreports
@@ -95,9 +96,14 @@ protected void onListItemClick(ListView l, View v, int position, long id) {
     }
 
     private void scanDirectory() {
-        File[] files = REPORT_DIR.listFiles();
         mAdapter.clear();
         mFiles.clear();
+
+        File[] files = REPORT_DIR.listFiles();
+        if (files == null) return;
+
+        // Sort in reverse order: newest bug reports first
+        Arrays.sort(files, Collections.reverseOrder());
         for (int i = 0; i < files.length; i++) {
             String name = files[i].getName();
             if (name.endsWith(".gz")) name = name.substring(0, name.length() - 3);
@@ -106,13 +112,9 @@ private void scanDirectory() {
                 continue;
             }
 
+            // Make sure to keep the parallel arrays in sync
             mAdapter.add(name.substring(10, name.length() - 4));
             mFiles.add(files[i]);
         }
-
-        // Reverse sort order: newest first.
-        mAdapter.sort(new Comparator<String>() {
-            public int compare(String a, String b) { return b.compareTo(a); }
-        });
     }
 }