Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Search should search all files #60

Open
2 tasks done
pfuhlert opened this issue Jan 2, 2024 · 4 comments
Open
2 tasks done

[Feature Request] Search should search all files #60

pfuhlert opened this issue Jan 2, 2024 · 4 comments
Assignees
Labels
feature request Request for new feature hindered-by-vscode The development is hindered by absent of appropriate VS Code API.
Milestone

Comments

@pfuhlert
Copy link

pfuhlert commented Jan 2, 2024

Disclaimer

Please make sure all the items below is checked (i.e., prefixed with "- [x]")

  • The request feature has not been addressed in the feature request list.
  • The design of the feature does not require detailed discussion, or existing discussion with drawn conclusion can be found in Discussions Area at: [paste the link here]

Motivation

Hi and thank you for this awesome project! I'm using it rn for my PhD thesis 👍 When going to the vscode search (ctrl+shift+f), only opened files are searched. It would be massively helpful if all files in the current project are searched.

@pfuhlert pfuhlert added the feature request Request for new feature label Jan 2, 2024
@iamhyc iamhyc self-assigned this Jan 2, 2024
@iamhyc iamhyc added bug Something isn't working and removed feature request Request for new feature labels Jan 2, 2024
@iamhyc
Copy link
Owner

iamhyc commented Jan 2, 2024

Thanks for your feedback! I need some time to figure out the root cause.

As a workaround, you can try to "Open Project Locally" which is not suffered from the inconvenience of virtual filesystem.

@iamhyc iamhyc added this to the v0.8.0 milestone Jan 2, 2024
@pfuhlert
Copy link
Author

pfuhlert commented Jan 2, 2024

Thank you! The workaround works and I think I did the same thing before by just checking out my overleaf repository via git clone locally in another window (and thus cannot compile using overleaf.com). Or does this do something else? Thanks anyway in advance!

@iamhyc
Copy link
Owner

iamhyc commented Jan 2, 2024

Thank you! The workaround works and I think I did the same thing before by just checking out my overleaf repository via git clone locally in another window (and thus cannot compile using overleaf.com). Or does this do something else? Thanks anyway in advance!

You mean the local folder opened and your git folder are the same one? If your git repo is linked with Overleaf, then there should be no problem. Otherwise you may need git diff to check the difference.

Every time you open that folder with .overleaf folder presence in vscode, the extension will force overwrite the folder with the content stored on Overleaf.
Besides, the compile and pdf preview service are disabled in the local folder, and you may need to refer to LaTeX Workshop.

@iamhyc
Copy link
Owner

iamhyc commented Jan 5, 2024

I find the search in the virtual filesystem will stuck at the very first start: it simply cannot see any file.

It appears to be a vscode bug. I will report it on the vscode repo later.


Update: We need to implement a TextSearchProvider to enable search file content. However, the related api proposal is still under discussion in microsoft/vscode#59921 , which can only be used in "vscode-insiders" release with proper launch argument set by users.

We will wait for it merged in mainline to take next move.

@iamhyc iamhyc added the hindered-by-vscode The development is hindered by absent of appropriate VS Code API. label Jan 5, 2024
@iamhyc iamhyc modified the milestones: v0.8.0, v1.0.0 Jan 6, 2024
@iamhyc iamhyc added feature request Request for new feature and removed bug Something isn't working labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new feature hindered-by-vscode The development is hindered by absent of appropriate VS Code API.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants