Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good vertical rhythm #35

Closed
eduarddotgg opened this issue Jul 7, 2015 · 1 comment
Closed

Good vertical rhythm #35

eduarddotgg opened this issue Jul 7, 2015 · 1 comment
Labels

Comments

@eduarddotgg
Copy link

How good vertical rhythm look likes based on this settings? i have tried to use another font-faces and could figure out and configure to look good. and for example where should margin be before red line (debug grid) or outside?

@ianrose
Copy link
Owner

ianrose commented Aug 5, 2015

@Admdh good questions. Each typeface will have different characteristics that affect line-height, size, and line length. The default settings should be treated as a good starting point and I encourage you to tinker with them as a designer to find the right sweet spot.

As for the margin example if you use the emRhythm function the margin should be a multiple of your base vertical unit https://github.com/ianrose/typesettings/blob/master/_typesettings.scss#L37. The base vertical unit value is used to create the body baseline. So often there will be times when it will not land directly on the debug grid.

A good read on the topic: http://www.smashingmagazine.com/2012/12/css-baseline-the-good-the-bad-and-the-ugly/

@ianrose ianrose closed this as completed Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants