Skip to content

Commit 3567f3d

Browse files
committed
Bug 958554 - Fix about window sometimes saying nightly is being updatd by another instance. r=rstrong
Note that if the process is hung, or there is another instance running in a different user instance, or another profile is running, the message is perfectly normal. But this should prevent the bad case of getting this message. This handling was first added specifically for Metro and Firefox running the same intallation at the same time. Metro isn't being released but there are still other very valid reasons for having this handling as noted above.
1 parent f76af0c commit 3567f3d

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

toolkit/mozapps/update/nsUpdateService.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2078,6 +2078,14 @@ UpdateService.prototype = {
20782078
Services.obs.removeObserver(this, topic);
20792079
Services.prefs.removeObserver(PREF_APP_UPDATE_LOG, this);
20802080

2081+
#ifdef XP_WIN
2082+
// If we hold the update mutex, let it go!
2083+
// The OS would clean this up sometime after shutdown,
2084+
// but that would have no guarantee on timing.
2085+
if (gUpdateMutexHandle) {
2086+
closeHandle(gUpdateMutexHandle);
2087+
}
2088+
#endif
20812089
if (this._retryTimer) {
20822090
this._retryTimer.cancel();
20832091
}

0 commit comments

Comments
 (0)