Skip to content

Commit

Permalink
Bug 958554 - Fix about window sometimes saying nightly is being updat…
Browse files Browse the repository at this point in the history
…d by another instance. r=rstrong

Note that if the process is hung, or there is another instance running in a  different user instance,
or another profile is running, the message is perfectly normal.  But this should prevent the bad case
of getting this message.

This handling was first added specifically for Metro and Firefox running the same intallation at the
same time.  Metro isn't being released but there are still other very valid reasons for having this
handling as noted above.
  • Loading branch information
bbondy committed Sep 29, 2014
1 parent f76af0c commit 3567f3d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions toolkit/mozapps/update/nsUpdateService.js
Original file line number Diff line number Diff line change
Expand Up @@ -2078,6 +2078,14 @@ UpdateService.prototype = {
Services.obs.removeObserver(this, topic);
Services.prefs.removeObserver(PREF_APP_UPDATE_LOG, this);

#ifdef XP_WIN
// If we hold the update mutex, let it go!
// The OS would clean this up sometime after shutdown,
// but that would have no guarantee on timing.
if (gUpdateMutexHandle) {
closeHandle(gUpdateMutexHandle);
}
#endif
if (this._retryTimer) {
this._retryTimer.cancel();
}
Expand Down

0 comments on commit 3567f3d

Please sign in to comment.