From bc85562fe4b4260f2dce15591097cdbfab5f8b86 Mon Sep 17 00:00:00 2001
From: Nico Grunbaum <na-g@nostrum.com>
Date: Wed, 31 May 2023 19:58:01 +0000
Subject: [PATCH] Bug 1830790 - P16 - remove localSdp and remoteSdp from
 internal stats report;r=bwc,webidl,smaug

Differential Revision: https://phabricator.services.mozilla.com/D178978
---
 dom/media/webrtc/WebrtcGlobal.h               | 4 ++--
 dom/media/webrtc/jsapi/PeerConnectionImpl.cpp | 4 ----
 dom/webidl/RTCStatsReport.webidl              | 2 --
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/dom/media/webrtc/WebrtcGlobal.h b/dom/media/webrtc/WebrtcGlobal.h
index 9e81c549ee89a..dac51dcf6bbbd 100644
--- a/dom/media/webrtc/WebrtcGlobal.h
+++ b/dom/media/webrtc/WebrtcGlobal.h
@@ -119,8 +119,8 @@ struct ParamTraits<mozilla::dom::RTCStatsCollection> {
 
 DEFINE_IPC_SERIALIZER_WITH_SUPER_CLASS_AND_FIELDS(
     mozilla::dom::RTCStatsReportInternal, mozilla::dom::RTCStatsCollection,
-    mClosed, mLocalSdp, mSdpHistory, mPcid, mBrowserId, mRemoteSdp, mTimestamp,
-    mCallDurationMs, mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
+    mClosed, mSdpHistory, mPcid, mBrowserId, mTimestamp, mCallDurationMs,
+    mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
 
 typedef mozilla::dom::RTCStats RTCStats;
 
diff --git a/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp b/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp
index 353b6e7a07add..567b682b2a61f 100644
--- a/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp
+++ b/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp
@@ -3737,10 +3737,6 @@ RefPtr<dom::RTCStatsReportPromise> PeerConnectionImpl::GetStats(
           mJsepSession->GetLocalDescription(kJsepDescriptionPendingOrCurrent);
       std::string remoteDescription =
           mJsepSession->GetRemoteDescription(kJsepDescriptionPendingOrCurrent);
-      report->mLocalSdp.Construct(
-          NS_ConvertASCIItoUTF16(localDescription.c_str()));
-      report->mRemoteSdp.Construct(
-          NS_ConvertASCIItoUTF16(remoteDescription.c_str()));
       if (!report->mSdpHistory.AppendElements(mSdpHistory, fallible)) {
         mozalloc_handle_oom(0);
       }
diff --git a/dom/webidl/RTCStatsReport.webidl b/dom/webidl/RTCStatsReport.webidl
index bd5abcdbc849f..f10e4b56d3a89 100644
--- a/dom/webidl/RTCStatsReport.webidl
+++ b/dom/webidl/RTCStatsReport.webidl
@@ -311,8 +311,6 @@ dictionary RTCStatsReportInternal : RTCStatsCollection {
   required unsigned long                    browserId;
   RTCConfigurationInternal                  configuration;
   DOMString                                 jsepSessionErrors;
-  DOMString                                 localSdp;
-  DOMString                                 remoteSdp;
   // TODO demux from RTCStatsReportInternal in bug 1830824
   sequence<RTCSdpHistoryEntryInternal>      sdpHistory = [];
   required DOMHighResTimeStamp              timestamp;