Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implausible test cases of HpModelSpec #1042

Closed
danielfeismann opened this issue Nov 22, 2024 · 0 comments · Fixed by #1044
Closed

Fix implausible test cases of HpModelSpec #1042

danielfeismann opened this issue Nov 22, 2024 · 0 comments · Fixed by #1044
Assignees
Labels
bug Something isn't working test Issues related to (unit) tests

Comments

@danielfeismann
Copy link
Member

HpState(
isRunning = true,
0,
Some(hpData.ambientTemperature),
Kilowatts(95d),
Kilowatts(80d),
thermalState(Celsius(17)),
None,
),
true,
95,
15.6,
Some(HouseTemperatureUpperBoundaryReached(31711L)),
),

if the Hp is running in the lastState, the thermalState need to be set up with the qDot of the Hp not only with some temperature (at least if no storage or any other heat sink is available).

@danielfeismann danielfeismann added the invalid Issue is not applicable label Nov 22, 2024
@danielfeismann danielfeismann self-assigned this Nov 22, 2024
@sebastian-peter sebastian-peter added bug Something isn't working test Issues related to (unit) tests and removed invalid Issue is not applicable labels Nov 22, 2024
sebastian-peter added a commit that referenced this issue Nov 22, 2024
…test-cases-of-HpModelSpec

Fix implausible test cases of HpModelSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues related to (unit) tests
Projects
None yet
2 participants