Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and correct line length in vnSimona #644

Open
danielfeismann opened this issue Nov 6, 2023 · 7 comments
Open

Check and correct line length in vnSimona #644

danielfeismann opened this issue Nov 6, 2023 · 7 comments
Assignees
Labels

Comments

@danielfeismann
Copy link
Member

Log statement of vnSimona runs contian several statements concerning line length beeing 50% greater than distance. This should be adapted.

13:56:29.454 WARN  e.i.d.u.validation.ValidationUtils - Line length is more than 50.0% greater than the calculated distances between points building the line: LineInput{uuid=63be5ffd-acbc-4c4f-aab9-54c616e2dd2e, id=LTG_NS_NET126_F4_(9)-NS_NET126_F4_(10), operator=a2c896f4-d661-4248-89ff-99e94d08773e, operationTime=OperationTime{startDate=null, endDate=null, isLimited=false}, nodeA=119d270a-ff22-4fdb-8214-cb5b336790bf, nodeB=857c264a-7072-4bb7-af56-2f01539b2a2e, noOfParallelDevices=1, type=a4aab125-8af4-4ef9-8842-4cf718f998bc, length=0.032999999821186066 km, geoPosition=LINESTRING (7.4116482000001005 51.4843281000001, 7.4116482 51.4843281), olmCharacteristic=OlmCharacteristicInput{points=[CharacteristicCoordinate{x=0.0 m/s, y=1.0 p.u.}]}}

@danielfeismann danielfeismann added good first issue Good for newcomers log labels Nov 6, 2023
@danielfeismann
Copy link
Member Author

Other warnings might be checked as well:

Entity may be unsafe because of: Measurement Unit does not measure any values [MeasurementUnitInput{uuid=b400da1c-8f46-463a-92aa-28ec48391a7b, id=regulate_transformers, operator=a2c896f4-d661-4248-89ff-99e94d08773e, operationTime=OperationTime{startDate=null, endDate=null, isLimited=false}, node=15345698-c319-461f-b969-37d50fb84220, vMag=false, vAng=false, p=false, q=false}]
 

@sebastian-peter sebastian-peter removed the good first issue Good for newcomers label Dec 13, 2023
@sebastian-peter
Copy link
Member

Entity may be unsafe because of: Measurement Unit does not measure any values

These ones are fixed in #672

@pierrepetersmeier
Copy link
Contributor

@danielfeismann The Warning is not coming from vnSimona but from PSDM, specifically in ConnectorValidtionUtils.Java at line 608.

@pierrepetersmeier
Copy link
Contributor

I haven't fully understood the code, but my assumption is as follows: In the default line_input.csv file, all nodes receive the default geoposition but have different lengths. When the lengths of the lines are checked against the nodes, they don't match up.

@pierrepetersmeier
Copy link
Contributor

To solve this, we could either adjust the lengths in the line_input.csv or increase the threshold from 50% to 60/70%. I need to delve deeper to find better solutions.

@danielfeismann
Copy link
Member Author

@pierrepetersmeier thank you for your feedback. Right, since we use PSDM to read the csv-files it is within PSDM (the validation may comes from PowerSystemUtils used in PSDM, haven't checked in detail).

My preference would be to keep the lengths as they are and change the coordinates. Since we don't have a method for generating coordinates that would meet the topology and length requirements here, there are three options.

  1. we skip this, label it by `Won't fix'.
  2. develop a method that does this (e.g. using pypsdm)
  3. do it manually (in which case I suggest distributing this among (future) contributors, e.g. everyone 15 nodes)

@pierrepetersmeier
Copy link
Contributor

If this method can be used for future projects and I'm not underestimating the scope right now, I would attempt to develop a method. Otherwise, I would start manually changing the coordinates. What characteristics must the coordinates have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants