Remove getter

It's not generally pythonic to have a "getter" like this - you usually want to just access the object's attributes directly.  It looks like you're signalling to the end user that the width and height aren't part of the object's public API.  I think it's more clean to skip this (and in fact, I'd change the names from _width and _height to width and height).  Others may disagree :)

Author: akaptur

ResizeDemo.py

@@ -18,15 +18,15 @@
 sc = SeamCarverLib.SeamCarver(pic)
 
 print "print vertical seam 1"
-print sc.width(), sc.height()
+print sc._width, sc._height
 #SeamCarverUtilities.printVerticalSeamEnergy(sc)
 SeamCarverUtilities.printSeam(sc, direction="vertical")
 #SeamCarverUtilities.distToArray(sc)
 
 print "remove vertical seam"
 s = sc.findVerticalSeam()
 sc.removeVerticalSeam(s)
-print sc.width(), sc.height()
+print sc._width, sc._height
 print "find vertical seam"
 SeamCarverUtilities.printSeam(sc, direction="vertical")
 
@@ -38,7 +38,7 @@
 print "remove horizontal seam"
 s = sc.findHorizontalSeam()
 sc.removeHorizontalSeam(s)
-print sc.width(), sc.height()
+print sc._width, sc._height
 #SeamCarverUtilities.printHorizontalSeamEnergy(sc)
 print "find horizontal seam"
 SeamCarverUtilities.printSeam(sc, direction="horizontal")
@@ -49,11 +49,11 @@
 # sc.removeVerticalSeam(s)
 
 # # print "print vertical seam 2"
-# print sc.width(), sc.height()
+# print sc._width, sc._height
 # SeamCarverUtilities.printVerticalSeam(sc)
 # #SeamCarverUtilities.printVerticalSeamEnergy(sc)			
 # # s = sc.findVerticalSeam()
-# # for i in range(sc.height()):
+# # for i in range(sc._height):
 # # 	print s[i]
 # # # print sc._edgeTo
 # # # print sc._distTo
@@ -62,42 +62,42 @@
 
 # s = sc.findVerticalSeam()
 # sc.removeVerticalSeam(s)
-# print sc.width(), sc.height()
+# print sc._width, sc._height
 
 # # print "print vertical seam 3"
-# # print sc.width(), sc.height()
+# # print sc._width, sc._height
 # SeamCarverUtilities.printVerticalSeam(sc)
 # SeamCarverUtilities.distToArray(sc)
 # #SeamCarverUtilities.printVerticalSeamEnergy(sc)			
 # # s = sc.findVerticalSeam()
-# # for i in range(sc.height()):
+# # for i in range(sc._height):
 # # 	print s[i]
 
 # s = sc.findVerticalSeam()
 # sc.removeVerticalSeam(s)
-# print sc.width(), sc.height()
+# print sc._width, sc._height
 
 # # print "print vertical seam 4"
-# # print sc.width(), sc.height()
+# # print sc._width, sc._height
 # SeamCarverUtilities.printVerticalSeam(sc)
 #SeamCarverUtilities.printVerticalSeamEnergy(sc)			
 # s = sc.findVerticalSeam()
-# for i in range(sc.height()):
+# for i in range(sc._height):
 # 	print s[i]
 
 # print "print vertical seam 2"
 # # print sc._edgeTo
 # # print sc._distTo
 # s = sc.findVerticalSeam()
 # sc.removeVerticalSeam(s)  							
-# print sc.height(), sc.width()	
+# print sc._height, sc._width	
 #SeamCarverUtilities.printVerticalSeam(sc) 			
 # print
 
 # print "print vertical seam 3"
 # s = sc.findVerticalSeam()							
 # sc.removeVerticalSeam(s) 							
-# print sc.height(), sc.width()
+# print sc._height, sc._width
 # # print sc._edgeTo
 # # print sc._distTo					
 # #pdb.set_trace()
@@ -107,15 +107,15 @@
 # print "remove vertical seam 4"
 # s = sc.findVerticalSeam()
 # sc.removeVerticalSeam(s)
-# print sc.height(), sc.width()
+# print sc._height, sc._width
 # # print sc._edgeTo
 # # print sc._distTo
 # SeamCarverUtilities.printVerticalSeam(sc)
 
 # print "remove vertical seam 5"
 # s = sc.findVerticalSeam()
 # sc.removeVerticalSeam(s)
-# print sc.height(), sc.width()
+# print sc._height, sc._width
 # SeamCarverUtilities.printVerticalSeam(sc)
 
 

SeamCarverLib.py

@@ -25,13 +25,6 @@ def __init__(self, picture):
 		self._edgeTo = []
 		self._distTo = []
 
-
-	def width(self):
-		return self._width
-
-	def height(self):
-		return self._height
-
 	def energy(self, col, row):
 		"""return energy of pixel in (col, row)"""
 		if self._isValid(col, row):

SeamCarverUtilities.py

@@ -5,8 +5,8 @@ def printSeam(sc, direction):
 	else:
 		seam = sc.findHorizontalSeam()
 
-	for row in range(sc.height()):
-		for col in range(sc.width()):
+	for row in range(sc._height):
+		for col in range(sc._width):
 			if direction == "vertical":
 				is_on_seam = col == seam[row]
 			else: