Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements to unit testing #953

Open
david-pfx opened this issue Mar 3, 2023 · 1 comment
Open

Usability improvements to unit testing #953

david-pfx opened this issue Mar 3, 2023 · 1 comment

Comments

@david-pfx
Copy link
Contributor

I'm working on merging the last year or so of PS changes into PuzzleScriptPlus, and there are plenty! Many of the changes depend on the test suite to confirm compatibility and to track down bugs, and it's giving me problems. It's a godsend, but it could be even better.

I would like to propose improvements to the test suite:

  1. to improve the ability to run tests in groups, or by name
  2. to improve the handling of errors, especially those that trigger exceptions or the ominous 'compilation aborted'.

I'm looking for feedback/suggestions/guidance. I'm happy to contribute to the work, but I'd like to know how to go about it so changes can be accepted.

@increpare
Copy link
Owner

  • Improve ability to run tests in group isn't something that interests me. The tests don't take that long to run, and I like the very low overhead right now of just throwing in new tests without having to think much about what exactly they are testing 😅 . (Though I can, for instance, imagine it being useful to people developing implementations only supporting a subset of features, or incrementally adding support as they develop it, that's beyond the scope of vanilla puzzlescript).
  • Giving better error output would definitely be a plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants