feat: update crossbuilder to tagged version and update go linker #26064
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanbenz
changed the title
devanbenz
force-pushed
the
db/update-cross-builder
branch
from
beea528 to
576dd4e
Compare
this includes a CGO_LDFLAGS env var when running go-test-compile
|
I'm going to merge this in so at least the windows build step works on all incoming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the build step failures for influxdb on windows amd64. Updates the cross builder to
go1.23.5-ba67b11de54aa0bf8f1f92a81f786205de8024b6
Adds
export CGO_LDFLAGS="-lntdll -ladvapi32 -lkernel32 -luserenv -lws2_32 ${CGO_LDFLAGS}"to cgo linker to link NT specific syscalls.Closes #26051