Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Export - Cross Browser Issues #65

Open
lee-nk opened this issue Sep 27, 2016 · 3 comments
Open

Web Export - Cross Browser Issues #65

lee-nk opened this issue Sep 27, 2016 · 3 comments
Labels

Comments

@lee-nk
Copy link

lee-nk commented Sep 27, 2016

Hi. I have just completed an entry for the 2016 IF Competition, using Ink and Inky, and using Inky's HTML export feature. While doing beta testing I have had some reports of some cross browser problems.

I have been testing in Chrome, where everything works fine. However, when I run the story in Firefox, I find that every time I click a divert, the html page scrolls right down right from the beginning of the story, which is eventually many pages long.

I have also had reports of the scroll-down not working at all, although this has been from users with older browsers.

I am unsure if it is related, but in the javascript console I see this error: Expected parent to be a container

I will attempt to debug the javascript myself, but I was wondering if there were any known workarounds to address this. Thanks.


UPDATE: I just looked at the recent Inky releases and noticed there was an update 18 days ago to address exactly this issue. I will try this out tonight, and report back. Thanks.

@leegrey
Copy link

leegrey commented Sep 27, 2016

Hi, sorry to switch accounts, I accidentally opened this issue with my work account (lee-nk).

I have updated Inky and the new exporter appears to work in Firefox. I do notice one strange behaviour, which is that after refreshing the page, all the previously clicked diverts have broken scrolling. It just jumps to the top of the scroll target, and the text fades in, in place. Then when you catch up to the place you were up to on the previous session it will begin to scroll correctly.

This is very strange to me, and I can't think why this would happen, unless there are some values being held in local storage, or some weird caching issue in the browser? I have a little TODO list of things I'd like to dig into, including that font size / zoom feature we discussed a few weeks ago. I should have some more time soon, so I will try to look into this firefox scrolling thing too, if no-one else is actively looking into it.

@joethephish
Copy link
Member

Sure, happy to receive a pull request on the Firefox issue! The web template's JavaScript code is pretty simple, so hopefully it should be easy enough to debug and fix. (Although what you say about refreshing the page sounds odd... we don't currently do any caching/localstorage stuff.)

@lunarcloud
Copy link
Contributor

Using Firefox 95 and Inky 0.12.0 - this is not an issue.
Recommend closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants