CORBER_PLATFORM undefined

[lougreenwood]

When following the guide for ember (http://corber.io/pages/frameworks/ember) - after updating my targets.js I get this error: Unknown browser undefined

If I inspect the contents of process.env I see that CORBER_PLATFORM is missing (only Corber-related env is process.env.CORBER)...

ember: 3.3.1
corber: 1.3.0
ember-cli: 3.3.0
node: 10.4.1
os: darwin x64

[alexblom]

Hi @lougreenwood - can you let me know if this issue has persisted as of 1.3.1 / 1.3.2?

[lougreenwood]

yep, looks like it, thanks!

[lougreenwood]

Actually, no, I spoke too soon... Seems it's still broken, I still get Unknown browser undefined on 1.3.2

[lougreenwood]

I just did some digging, I'm not sure it's a correct conclusion, but is this as simple as this line (https://github.com/isleofcode/corber/blob/master/lib/commands/build.js#L65) isn't called until after targets.js is parsed in the ember build process?

If I manually define CORBER_PLATFORM before building, everything works as expected

[alexblom]

I'm actually having trouble replicating this. Can you perhaps confirm that your global and project corber versions are in the 1.3.x range?

1.3.x involved some internal changes and you could hit compat issues with both installed.

[alexblom]

Closing due to inactivity, please re-open if you are still having this issue