Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to trigger replication / distribution #286

Closed
royteeuwen opened this issue Aug 26, 2022 · 6 comments
Closed

Not possible to trigger replication / distribution #286

royteeuwen opened this issue Aug 26, 2022 · 6 comments
Labels
enhancement solved

Comments

@royteeuwen
Copy link
Contributor

A feature that I have been missing so far is to trigger a replication / distribution from the Composum browser. Maybe I haven't found it yet? Would be a very handy addition
@royteeuwen
Copy link
Contributor Author

Fixed by #287

@stoerr stoerr mentioned this issue Feb 7, 2023
Closed
@stoerr
Copy link
Member

stoerr commented Feb 7, 2023 •
edited
Loading

Integrated into Composum Nodes release 4.1.3 .

@royteeuwen Thank you very much for your contribution! The new profile autoInstallPackage is also a nice touch. 😄

I improved it a little with #293 to display a success message, too. Could you perhaps try that? It should display something like 'Replication started for /content/whatever/page' now. I'm not very sure whether the format /bin/replicate.json returns changes over the AEM versions. Unfortunately I couldn't convince it to actually return JSON, as the URL says. 😞 This just changes /apps/composum/nodes/browser/components/extra-actions/clientlib/js/extra-actions.js , so you could also replace that file by the new content to try it out.

For me /bin/response.json gave back something like:

<html>
<head>
    <title></title>
</head>
    <body>
    <h1></h1>
    <table>
        <tbody>
            <tr>
                <td>Status</td>
                <td><div id="Status">200</div></td>
            </tr>
            <tr>
                <td>Message</td>
                <td><div id="Message">Replication started for /content/we-retail/de/de
</div></td>
            </tr>
            <tr>
                <td>Location</td>
                <td><a href="" id="Location"></a></td>
            </tr>
            <tr>
                <td>Parent Location</td>
                <td><a href="" id="ParentLocation"></a></td>
            </tr>
            <tr>
                <td>Path</td>
                <td><div id="Path">/content/we-retail/de/de</div></td>
            </tr>
            <tr>
                <td>Referer</td>
                <td><a href="" id="Referer"></a></td>
            </tr>
            <tr>
                <td>ChangeLog</td>
                <td><div id="ChangeLog">&lt;pre&gt;&lt;/pre&gt;</div></td>
            </tr>
        </tbody>
    </table>
    <p><a href="">Go Back</a></p>
    <p><a href="">Modified Resource</a></p>
    <p><a href="">Parent of Modified Resource</a></p>
    </body>
</html>

@royteeuwen
Copy link
Contributor Author

royteeuwen commented Feb 7, 2023 •
edited
Loading

@stoerr did you try this out on an AEMaaCS SDK? I get back the following response, and so the following error popup "Unparseable response on activate"

{"path":["/content/my-site/fr"],"artifactId":[],"status.message":"Replication started for /content/my-site/fr\n","status.code":200}

@royteeuwen
Copy link
Contributor Author

royteeuwen commented Feb 7, 2023 •
edited
Loading

#294 to fix both situations ( I hope?)

@stoerr
Copy link
Member

stoerr commented Feb 8, 2023

@royteeuwen Thank you, good that you tested and improved that! Nice that Adobe later fixed /bin/replicate.json to return JSON.

@ist-rw Do you want to have a look at #294 ? I also set our branch feature/fix-extra-actions to that, to make it easier to test. But we checked that on AEM 6.5.x and AEMaaCS, so it's likely to work, and I think we can just merge it if you don't object to something in the Javascript.

@stoerr stoerr added the solved label Mar 22, 2023
@stoerr
Copy link
Member

stoerr commented Mar 22, 2023 •
edited
Loading

With the new release https://github.com/ist-dresden/composum-nodes/releases/tag/composum-nodes-4.2.1 there is the big closing time for solved issues. :-)

@stoerr stoerr closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stoerr @royteeuwen