Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod tolerations field is not removed #12

Open
itaysk opened this issue Oct 28, 2019 · 2 comments
Open

Pod tolerations field is not removed #12

itaysk opened this issue Oct 28, 2019 · 2 comments

Comments

@itaysk
Copy link
Owner

itaysk commented Oct 28, 2019

a "neat" pod still has the tolerations field intact. need to investigate why this is not recognized as a default, or think if it make sense to manually clean as part of NeatPod.

@itaysk
Copy link
Owner Author

itaysk commented Dec 7, 2019

it's being added by a built-in admission controller: https://github.com/kubernetes/kubernetes/tree/master/plugin/pkg/admission/defaulttolerationseconds

@itaysk
Copy link
Owner Author

itaysk commented Dec 7, 2019

might be a good idea to look at admission controllers systematically, if there's a way to "default" their actions. if not, make sure at least the default ones are covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant