Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width of CJK character change when line contains escaped chars #38

Closed
QiangF opened this issue May 10, 2019 · 5 comments
Closed

Width of CJK character change when line contains escaped chars #38

QiangF opened this issue May 10, 2019 · 5 comments
Assignees
Labels

Comments

@QiangF
Copy link

QiangF commented May 10, 2019

Normally one CJK character equal two english character width, the following will be closed.

+----+
| 一 |
+----+

If the line contains escape qutoe, the CJK character seems need 3 english character spaces to get
the shape closed.

+--------+
|"""一"""|
+--------+

I am using svgbob 0.3.2.

@QiangF QiangF changed the title Width of CJK character change between quote Width of CJK character change when line contains escaped chars May 10, 2019
@QiangF
Copy link
Author

QiangF commented May 24, 2019

If there is no extra spaces between CJK characters, the quote is not needed. Is it possible to prevent each CJK characters being treated as a separate element as described in the first FAQ?

@m-h-k
Copy link

m-h-k commented Jan 28, 2021

I have a similar issue with German "umlauts" and svgbob 0.4.1:

+----------+
| ÖÄÜ      |
+----------+

+----------+
| "ÖÄÜ"    |
+----------+

+----------+
| "ÖÄÜ" |
+----------+

will be converted to

test

@ivanceras ivanceras self-assigned this Aug 16, 2021
@ivanceras ivanceras added the bug label Aug 16, 2021
@ivanceras
Copy link
Owner

This even panics in the new version of svgbob (0.5.3) . I'm reviewing old code what has make this code panics.

@ivanceras
Copy link
Owner

Fixed in this commit 5a2eae1

@ivanceras
Copy link
Owner

Published svgbob 0.5.5, with a fix on this.
Online editor works as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants