Git gui does not respect core.commentchar

[Si-So]

Unlike regular Git, git gui does not respect the core.commentchar configuration. This issue was introduced here: 1ae85ff

This change affects my workflow because I start every commit message with a ticket number in the following format:

#123456: commit message

With the new behavior, git gui incorrectly treats my ticket number as a comment.

[j6t]

@ossilator Can you please have a look? A fix would be very much appreciated.

[ossilator]

i was hoping i could avoid it. 😇
note that this isn't an entirely trivial exercise, as i pointed out here.

[j6t]

In this comment you mention commit.cleanup and commit --cleanup. But we can simplify this a lot: We only need support for commit.commentChar and commit.commentString.

[ossilator]

it depends on what level of compliance the user expects. the request here is also "just" a step up.

i admit that i cannot make sense of the "auto" setting, how it would fit into actual execution flows. it seems woefully under-documented. i'm tempted to just ignore it.

[mondjunge]

I have basically the same issue.