Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations #6059

Open
2 of 6 tasks
mahadzaryab1 opened this issue Oct 6, 2024 · 2 comments
Open
2 of 6 tasks

Comments

@mahadzaryab1
Copy link
Contributor

mahadzaryab1 commented Oct 6, 2024

Requirement

In this issue, we want to align the configuration for elastic search and open search storage with OTEL (part of #5229)

Problem

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
  • Configs implement Validate()
  • Configs via YAML support the same defaults as in jaeger-v1
  • Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.
  • Configuration looks "logical" and properly grouped, not flattened with long weird names
  • We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
@mahadzaryab1
Copy link
Contributor Author

@yurishkuro is a migration guide needed here?

@yurishkuro
Copy link
Member

yes, certainly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants