Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove colemak-dh patch ? #1735

Closed
jacmoe opened this issue Sep 25, 2023 · 2 comments · Fixed by #1741
Closed

Remove colemak-dh patch ? #1735

jacmoe opened this issue Sep 25, 2023 · 2 comments · Fixed by #1741

Comments

@jacmoe
Copy link
Contributor

jacmoe commented Sep 25, 2023

In PR #1587 a patch for colemak was added, effectively replacing the existing colemak-dh patch, but colemak-dh was not removed.

Maybe it is time to actually remove it?
I wouldn't want support for colemak being dropped because of the overhead of having to maintain two separate patches for colemak when only one of them is actually used.
@N-R-K
Copy link
Collaborator

N-R-K commented Sep 29, 2023 •
edited
Loading

I support removing the colemak-dh patch. If needed, we can link to it in the wiki or something for people who still want it.

@jarun
Copy link
Owner

jarun commented Sep 30, 2023

Please raise the PR.

N-R-K added a commit to N-R-K/nnn that referenced this issue Sep 30, 2023
@N-R-K
rm colemak-dh
336ec8b 
one colemak patch ought to be enough.

Closes: jarun#1735
@N-R-K N-R-K mentioned this issue Sep 30, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm colemak-dh N-R-K/nnn
3 participants
@jacmoe @jarun @N-R-K