Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name event "socket" why not "accept"? #8

Open
uasan opened this issue Sep 24, 2021 · 1 comment
Open

Name event "socket" why not "accept"? #8

uasan opened this issue Sep 24, 2021 · 1 comment

Comments

@uasan
Copy link

uasan commented Sep 24, 2021

Usually this event is called accept, plus the event name must be a verb

socketListener.addEventListener('accept', ...);

Maybe better?

@jasnell
Copy link
Owner

jasnell commented Nov 9, 2021

I'd like to leave the option of SocketListener becoming a mixin, potentially for the globalThis in some environments. In that case, accept might be too generic of a term, while socket is more specific to what you're listening for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants