Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in dynamic #23

Open
JesmonX opened this issue Nov 4, 2024 · 4 comments
Open

error in dynamic #23

JesmonX opened this issue Nov 4, 2024 · 4 comments

Comments

@JesmonX
Copy link

JesmonX commented Nov 4, 2024

When I run run_train_dynamic.py with compilable SCENIC code generated by your /ChatScene/retrieve/retrieve.py, it sometimes(maybe always) occuers a mistake of ZeroDivisionError: float division by zero after already building a scenario in carla. The detaild error is at the picture followed.
24d2d4c18cb001295beda33a8d13ac08
And there is another problem with /ChatScene/retrieve/retrieve.py, it always generate uncompilable scenic code. Is it normal or there is some problem in database?

@javyduck
Copy link
Owner

javyduck commented Nov 4, 2024

For the first question, the error "ZeroDivisionError: float division by zero" indicates that there is no record for even one frame, as the simulation hasn’t started as you can see from the log entry: "scenario stops due to scenic termination."

For the second question, I recently updated the database including more diverse snippets, and previously, the agent type was specified directly in the snippet, but I’ve now implemented it as a placeholder for extraction. This change may cause some compatibility issues. I will work on fixing it as soon as possible (apologies for the delay; I've been quite busy recently...)

@JesmonX
Copy link
Author

JesmonX commented Nov 5, 2024

But how to fix the first problem? I think it's because the scenic code is not that correct to some degree even it could go through the compilation. And I did not see similiar issue in the git repo of scenic.

@javyduck
Copy link
Owner

The thing is, in the senic repository, all the scripts there are written manually. However, in our repository, they are generated either through retrieval or by GPT, so there might be some errors in the final code. You can manually check and fix the generated code, or you can use GPT to automatically correct it. I’ll also refine it into a better version later. Apologies for being too busy recently...

@jeromefan
Copy link

I agree with @JesmonX 's point of view. I also encountered the same problem when using LLM-generated scenic scripts, which happens frequently. Could you enlighten us on which parts of the Scenic script should be examined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants