AutoMod: fix needs_media_data for compound checks

Previously, a rule would be considered to need media data if any checks
included a media check at all. For example, a check that looked at both
the submission's title and the media_title for a particular word would
not be applied to posts without media data. However, when in a compound
check like this, we should consider the media data optional, since there
are other non-media places that can be checked without it. This commit
does that, changing it so that a check will only cause the rule to
require media data if ALL of the fields being checked come from the
media, instead of if ANY of them do.

Author: Deimos

r2/r2/lib/automoderator.py

@@ -718,8 +718,10 @@ def get_match_patterns(self, values):
     @property
     def needs_media_data(self):
         """Whether the component requires data from the media embed."""
-        if any(field.startswith("media_") for field in self.match_fields):
-            return True
+        for key in self.match_patterns:
+            fields = self.parse_match_fields_key(key)["fields"]
+            if all(field.startswith("media_") for field in fields):
+                return True
 
         # check if any of the fields that support placeholders have media ones
         potential_placeholders = [self.report_reason]