Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG_CONFIG_HOME request #99

Closed
mcritchlow opened this issue Aug 17, 2018 · 7 comments
Closed

Support XDG_CONFIG_HOME request #99

mcritchlow opened this issue Aug 17, 2018 · 7 comments
Labels
fixed in next Fixed in git, awaiting release wishlist

Comments

@mcritchlow
Copy link

Would you consider supporting the standard XDG_CONFIG_HOME ~/.config for pius? This would prevent yet another dot directory in HOME.

It looks like there's been some work in this context before that supports backward compatibility for older config files, but I'm not familiar enough with the codebase to take a stab at it myself.

Either way, thanks for the great tool.

@F9Alejandro
Copy link

F9Alejandro commented Sep 10, 2018

You can change the constants.py in libpius directory for the variable "PIUS_HOME".
So instead of it being:
PIUS_HOME = os.path.join(HOME, '.pius')
it will be:
PIUS_HOME = os.path.join(HOME, '.config')
That should be the only file that needs to be changed.
Just use the commands to build and install as normal:
./setup.py build && sudo ./setup.py install

@jaymzh
Copy link
Owner

jaymzh commented Sep 10, 2018

I will add support for XDG_CONFIG_HOME - just need to get around to doing this and adding the proper back-compat stuff

@F9Alejandro
Copy link

Doing a bit of testing should be able to tell if XDG_CONFIG_HOME is an env variable, if not then it will check to see if directory .config exists, else it will stick with the fallback of .pius

@F9Alejandro
Copy link

#104 should contain the enhancement you are looking for.

@jaymzh jaymzh added the wishlist label Feb 9, 2019
jaymzh added a commit that referenced this issue Jul 2, 2019
* This adds a new PIUS_DEBUG environment variable for enabling debug
early
* This adds support for XDG_CONFIG_HOME and XDG_DATA_HOME (Fixes #99)
* refactors quite a bit of Util into a new class
@jaymzh
Copy link
Owner

jaymzh commented Jul 2, 2019

Support is now in the 3_work branch in f4b4e09 and will be in PIUS 3.x

@jaymzh jaymzh added the fixed in next Fixed in git, awaiting release label Jul 2, 2019
@jaymzh
Copy link
Owner

jaymzh commented Jul 5, 2019

3.0.0 is now out which fixes this.

@jaymzh jaymzh closed this as completed Jul 5, 2019
@mcritchlow
Copy link
Author

@jaymzh - Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next Fixed in git, awaiting release wishlist
Projects
None yet
Development

No branches or pull requests

3 participants