Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Vec and Matrix conversion #9

Closed
2 tasks
jdwhite48 opened this issue Jan 31, 2022 · 1 comment
Closed
2 tasks

Optimize Vec and Matrix conversion #9

jdwhite48 opened this issue Jan 31, 2022 · 1 comment
Assignees
@jdwhite48
Labels
good first issue Good for newcomers optimization This code could be faster restructure The API could be organized better

Comments

@jdwhite48
Copy link
Owner

  • Refactor col_vec_to_vec and vec_to_col_vec into appropriate Into / From functions
  • Rewrite their code to more efficiently convert between Vec<_> and Vec<Vec<_>> representations (i.e. Matrix<_>)
@jdwhite48 jdwhite48 added optimization This code could be faster restructure The API could be organized better labels Jan 31, 2022
@jdwhite48 jdwhite48 self-assigned this Jan 31, 2022
@jdwhite48 jdwhite48 added the good first issue Good for newcomers label Jan 31, 2022
@jdwhite48
Copy link
Owner Author

Hereafter, I will rely on existing conversions between matrices and vectors from the nalgebra library to whatever extent possible once the 12-integrate-matrix-libs branch (also see #12) merges into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdwhite48 jdwhite48

Labels
good first issue Good for newcomers optimization This code could be faster restructure The API could be organized better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdwhite48