Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make movie library genre "view all x" button match the one in TV library #1389

Open
cewert opened this issue Sep 23, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@cewert
Copy link
Member

cewert commented Sep 23, 2023

Software Versions

  • Jellyfin Server Version:
  • Roku Client Version: unstable

Describe the bug

if there are more than 6 movies in a genre, an item is added on the far left to allow the user to see all of the movies in that genre. That button is not shpwing up correctly and isn't showing the right items when selected

How To Reproduce

  1. Go to movie library
  2. hit star
  3. go to view
  4. Bselect genres
  5. hit back
  6. observe the far left item on a genre that has more items than 6
  7. select the far left item
  8. observe the results

Expected behavior

should work like the tv show library. that one works

Logs

Screenshots

Connection Information

  • Is server local or remote?
  • Is server connection HTTP or HTTPS?

Additional context

@cewert cewert added the bug Something isn't working label Sep 23, 2023
@1hitsong
Copy link
Member

I can't recreate this bug on neither current release nor your quickplay branch. Can you post a screenshot of what issues you're seeing?

@cewert cewert added enhancement New feature or request and removed bug Something isn't working labels Sep 24, 2023
@cewert cewert changed the title Movie library genre view - "Show all x" item broken Make movie library genre "view all x" button match the one in TV library Sep 24, 2023
@cewert
Copy link
Member Author

cewert commented Sep 24, 2023

Talked about this in chat and it's not a bug since it was designed this way. Changing to a feature request because I think the TV library genre view is a better UX.

On TV library, the button has black background with white text saying "View All genreName" and when selected, the overhang says "View All genreName".

vs

On movie library, the button has no black background and no text, just a "genre" image with items from that genre. One of the items shown is a TV series and one of them is a movie I don't have access to. Even if all the genre images were the right type and were items I have access to, I still think the text is needed to explain what selecting the item will do. Once selected, there is no overhang text tell the user what they are looking at. I thought this was bugged because it took me to my movie library and showed all my movies but in reverse order because all my movies rn have the same genre 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants